code refactor

This commit is contained in:
MaysWind 2017-03-19 23:46:16 +08:00
parent f7908c9a60
commit 81bcbb8291
2 changed files with 47 additions and 25 deletions

View file

@ -75,7 +75,47 @@
} }
}; };
$scope.settingService = ariaNgSettingService; $scope.setLanguage = function (value) {
ariaNgSettingService.setLanguage(value);
};
$scope.setDebugMode = function (value) {
ariaNgSettingService.setDebugMode(value);
};
$scope.setTitle = function (value) {
ariaNgSettingService.setTitle(value);
};
$scope.setTitleRefreshInterval = function (value) {
ariaNgSettingService.setTitleRefreshInterval(value);
};
$scope.isSupportNotification = function () {
return ariaNgNotificationService.isSupportBrowserNotification() &&
ariaNgSettingService.isCurrentRpcUseWebSocket($scope.context.settings.protocol);
};
$scope.setEnableBrowserNotification = function (value) {
ariaNgSettingService.setBrowserNotification(value);
if (value && !ariaNgNotificationService.hasBrowserPermission()) {
ariaNgNotificationService.requestBrowserPermission(function (permission) {
if (!ariaNgNotificationService.isPermissionGranted(permission)) {
$scope.context.settings.browserNotification = false;
ariaNgCommonService.showError('You have disabled notification in your browser. You should change your browser\'s settings before you enable this function.');
}
});
}
};
$scope.setGlobalStatRefreshInterval = function (value) {
ariaNgSettingService.setGlobalStatRefreshInterval(value);
};
$scope.setDownloadTaskRefreshInterval = function (value) {
ariaNgSettingService.setDownloadTaskRefreshInterval(value);
};
$scope.addNewRpcSetting = function () { $scope.addNewRpcSetting = function () {
var newRpcSetting = ariaNgSettingService.addNewRpcSetting(); var newRpcSetting = ariaNgSettingService.addNewRpcSetting();
@ -109,24 +149,6 @@
$window.location.reload(); $window.location.reload();
}; };
$scope.isSupportNotification = function () {
return ariaNgNotificationService.isSupportBrowserNotification() &&
ariaNgSettingService.isCurrentRpcUseWebSocket($scope.context.settings.protocol);
};
$scope.setEnableBrowserNotification = function (value) {
ariaNgSettingService.setBrowserNotification(value);
if (value && !ariaNgNotificationService.hasBrowserPermission()) {
ariaNgNotificationService.requestBrowserPermission(function (permission) {
if (!ariaNgNotificationService.isPermissionGranted(permission)) {
$scope.context.settings.browserNotification = false;
ariaNgCommonService.showError('You have disabled notification in your browser. You should change your browser\'s settings before you enable this function.');
}
});
}
};
$('[data-toggle="popover"]').popover(); $('[data-toggle="popover"]').popover();
$rootScope.loadPromise = $timeout(function () {}, 100); $rootScope.loadPromise = $timeout(function () {}, 100);

View file

@ -23,7 +23,7 @@
<div class="setting-value col-sm-8"> <div class="setting-value col-sm-8">
<select class="form-control" style="width: 100%;" ng-model="context.settings.language" <select class="form-control" style="width: 100%;" ng-model="context.settings.language"
ng-options="type as language.displayName for (type, language) in context.languages" ng-options="type as language.displayName for (type, language) in context.languages"
ng-change="settingService.setLanguage(context.settings.language)"> ng-change="setLanguage(context.settings.language)">
</select> </select>
</div> </div>
</div> </div>
@ -34,7 +34,7 @@
<div class="setting-value col-sm-8"> <div class="setting-value col-sm-8">
<select class="form-control" style="width: 100%;" ng-model="context.sessionSettings.debugMode" <select class="form-control" style="width: 100%;" ng-model="context.sessionSettings.debugMode"
ng-options="option.value as (option.name | translate) for option in context.trueFalseOptions" ng-options="option.value as (option.name | translate) for option in context.trueFalseOptions"
ng-change="settingService.setDebugMode(context.sessionSettings.debugMode)"> ng-change="setDebugMode(context.sessionSettings.debugMode)">
</select> </select>
</div> </div>
</div> </div>
@ -55,7 +55,7 @@
</div> </div>
<div class="setting-value col-sm-8"> <div class="setting-value col-sm-8">
<input class="form-control" type="text" ng-model="context.settings.title" <input class="form-control" type="text" ng-model="context.settings.title"
ng-change="settingService.setTitle(context.settings.title); updateTitlePreview()"/> ng-change="setTitle(context.settings.title); updateTitlePreview()"/>
<em>[<span translate>Preview</span>] <span ng-bind="context.titlePreview"></span></em> <em>[<span translate>Preview</span>] <span ng-bind="context.titlePreview"></span></em>
</div> </div>
</div> </div>
@ -67,7 +67,7 @@
<div class="setting-value col-sm-8"> <div class="setting-value col-sm-8">
<select class="form-control" style="width: 100%;" <select class="form-control" style="width: 100%;"
ng-model="context.settings.titleRefreshInterval" ng-model="context.settings.titleRefreshInterval"
ng-change="settingService.setTitleRefreshInterval(context.settings.titleRefreshInterval)" ng-change="setTitleRefreshInterval(context.settings.titleRefreshInterval)"
ng-options="time.optionValue as (time.name | translate: {value: time.value}) for time in context.availableTime"> ng-options="time.optionValue as (time.name | translate: {value: time.value}) for time in context.availableTime">
</select> </select>
</div> </div>
@ -92,7 +92,7 @@
<div class="setting-value col-sm-8"> <div class="setting-value col-sm-8">
<select class="form-control" style="width: 100%;" <select class="form-control" style="width: 100%;"
ng-model="context.settings.globalStatRefreshInterval" ng-model="context.settings.globalStatRefreshInterval"
ng-change="settingService.setGlobalStatRefreshInterval(context.settings.globalStatRefreshInterval)" ng-change="setGlobalStatRefreshInterval(context.settings.globalStatRefreshInterval)"
ng-options="time.optionValue as (time.name | translate: {value: time.value}) for time in context.availableTime"> ng-options="time.optionValue as (time.name | translate: {value: time.value}) for time in context.availableTime">
</select> </select>
</div> </div>
@ -105,7 +105,7 @@
<div class="setting-value col-sm-8"> <div class="setting-value col-sm-8">
<select class="form-control" style="width: 100%;" <select class="form-control" style="width: 100%;"
ng-model="context.settings.downloadTaskRefreshInterval" ng-model="context.settings.downloadTaskRefreshInterval"
ng-change="settingService.setDownloadTaskRefreshInterval(context.settings.downloadTaskRefreshInterval)" ng-change="setDownloadTaskRefreshInterval(context.settings.downloadTaskRefreshInterval)"
ng-options="time.optionValue as (time.name | translate: {value: time.value}) for time in context.availableTime"> ng-options="time.optionValue as (time.name | translate: {value: time.value}) for time in context.availableTime">
</select> </select>
</div> </div>