From a7e1d3a1f04a0a6830b9dafe5b4cd1e909cdfe15 Mon Sep 17 00:00:00 2001 From: MaysWind Date: Sun, 12 Aug 2018 16:22:59 +0800 Subject: [PATCH] code refactor --- src/scripts/services/ariaNgLogService.js | 12 ++++++++---- src/scripts/services/ariaNgSettingService.js | 3 ++- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/scripts/services/ariaNgLogService.js b/src/scripts/services/ariaNgLogService.js index deeead2..b71ac08 100644 --- a/src/scripts/services/ariaNgLogService.js +++ b/src/scripts/services/ariaNgLogService.js @@ -1,7 +1,8 @@ (function () { 'use strict'; - angular.module('ariaNg').factory('ariaNgLogService', ['$log', 'moment', 'ariaNgConstants', 'ariaNgSettingService', function ($log, moment, ariaNgConstants, ariaNgSettingService) { + angular.module('ariaNg').factory('ariaNgLogService', ['$log', 'moment', 'ariaNgConstants', function ($log, moment, ariaNgConstants) { + var enableDebugLog = false; var cachedDebugLogs = []; var createNewCacheLogItem = function (msg, level, obj) { @@ -14,7 +15,7 @@ }; var pushLogToCache = function (msg, level, obj) { - if (!ariaNgSettingService.isEnableDebugMode()) { + if (!enableDebugLog) { return; } @@ -26,8 +27,11 @@ }; return { + setEnableDebugLog: function (value) { + enableDebugLog = value; + }, debug: function (msg, obj) { - if (ariaNgSettingService.isEnableDebugMode()) { + if (enableDebugLog) { if (obj) { $log.debug('[AriaNg Debug]' + msg, obj); } else { @@ -65,7 +69,7 @@ pushLogToCache(msg, 'ERROR', obj); }, getDebugLogs: function () { - if (ariaNgSettingService.isEnableDebugMode()) { + if (enableDebugLog) { return cachedDebugLogs; } else { return []; diff --git a/src/scripts/services/ariaNgSettingService.js b/src/scripts/services/ariaNgSettingService.js index 10fb453..c7a965c 100644 --- a/src/scripts/services/ariaNgSettingService.js +++ b/src/scripts/services/ariaNgSettingService.js @@ -1,7 +1,7 @@ (function () { 'use strict'; - angular.module('ariaNg').factory('ariaNgSettingService', ['$window', '$location', '$filter', '$translate', 'base64', 'amMoment', 'localStorageService', 'ariaNgConstants', 'ariaNgDefaultOptions', 'ariaNgLanguages', 'ariaNgCommonService', function ($window, $location, $filter, $translate, base64, amMoment, localStorageService, ariaNgConstants, ariaNgDefaultOptions, ariaNgLanguages, ariaNgCommonService) { + angular.module('ariaNg').factory('ariaNgSettingService', ['$window', '$location', '$filter', '$translate', 'base64', 'amMoment', 'localStorageService', 'ariaNgConstants', 'ariaNgDefaultOptions', 'ariaNgLanguages', 'ariaNgCommonService', 'ariaNgLogService', function ($window, $location, $filter, $translate, base64, amMoment, localStorageService, ariaNgConstants, ariaNgDefaultOptions, ariaNgLanguages, ariaNgCommonService, ariaNgLogService) { var browserFeatures = (function () { var supportLocalStroage = localStorageService.isSupported; var supportCookies = $window.navigator.cookieEnabled; @@ -270,6 +270,7 @@ }, setDebugMode: function (value) { sessionSettings.debugMode = value; + ariaNgLogService.setEnableDebugLog(value); }, getTitle: function () { return getOption('title');