From 3dc24d58b59ef63b3569fa75dbdd1ca7c8e56dfb Mon Sep 17 00:00:00 2001 From: Simon Bruder Date: Tue, 23 Jun 2020 17:23:00 +0200 Subject: [PATCH] Remove offset option All tested charts do not have an offset. The former offset implementation (which was not working) just cancelled out at charts with a specific bpm value. --- src/converter/ddr2osu.rs | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/src/converter/ddr2osu.rs b/src/converter/ddr2osu.rs index 2b58319..f19bdc7 100644 --- a/src/converter/ddr2osu.rs +++ b/src/converter/ddr2osu.rs @@ -39,13 +39,6 @@ impl FromStr for ConfigRange { pub struct Config { #[clap(skip = "audio.wav")] pub audio_filename: String, - #[clap( - long, - default_value = "180", - about = "Offset in milliseconds", - display_order = 5 - )] - pub offset: i32, #[clap( long = "no-stops", about = "Disable stops", @@ -96,9 +89,8 @@ impl fmt::Display for Config { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { write!( f, - "ddr2osu (+{}ms{} shock→{:?} hp{} acc{})", - self.offset, - if self.stops { " stops" } else { "" }, + "ddr2osu ({}shock→{:?} hp{} acc{})", + if self.stops { "stops " } else { "" }, self.shock_action, self.hp_drain, self.accuracy @@ -349,20 +341,6 @@ impl ssq::SSQ { let mut timing_points = Vec::new(); - timing_points.push(beatmap::TimingPoint { - time: 0, - beat_length: config.offset as f32, - meter: 4, - sample_set: beatmap::SampleSet::BeatmapDefault, - sample_index: 0, - volume: 0, - uninherited: true, - effects: beatmap::TimingPointEffects { - kiai_time: false, - omit_first_barline: false, - }, - }); - for entry in &self.tempo_changes.0 { if config.stops || entry.beat_length != f32::INFINITY { trace!("Converting {:?} to to timing point", entry);